feat(EditorView): changed default selection styles #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiteformed
changed the title
|
Preview is ready. |
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
from
f3b5c46 to
e3db0bc
Compare
whiteformed
commented
Dec 10, 2024
Comment on lines
12
to
13
| // TODO: CHANGE TO TOKEN | ||
| $default-selection-background: #e6e6e6; |
There was a problem hiding this comment.
needs semantic css token before merging
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
from
e3db0bc to
0ae5e41
Compare
d3m1d0v
reviewed
Dec 10, 2024
Comment on lines
31
to
54
| '--g-selection-bg-color': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection bg color', | ||
| }, | ||
| '--g-selection-border': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection border', | ||
| }, | ||
| '--g-selection-border-radius': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection border radius', | ||
| }, | ||
| '--g-selection-outline': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection outline', | ||
| }, | ||
| '--g-selection-background': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection background', | ||
| }, | ||
| '--g-selection-box-shadow': { | ||
| control: {type: 'text'}, | ||
| description: 'Editor selection box-shadow', | ||
| }, |
There was a problem hiding this comment.
Let's change css-vars to --g-md-wysiwyg-selection-*
| control: {type: 'text'}, | ||
| description: 'Editor selection outline', | ||
| }, | ||
| '--g-selection-background': { |
There was a problem hiding this comment.
--g-selection-bg-color and --g-selection-background – are these duplicate variables?
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
3 times, most recently
from
d5ffabc to
d4179c1
Compare
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
from
1acd755 to
c2ba786
Compare
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
from
300657a to
70f1fcf
Compare
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
2 times, most recently
from
4c9ec08 to
c2106f2
Compare
whiteformed
force-pushed
the
feat/change-default-selection-styles
branch
from
c2106f2 to
0f513ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default selection styles;
Add css variables for customization.